Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare JDK 23 #370

Merged
merged 1 commit into from
Aug 20, 2024
Merged

prepare JDK 23 #370

merged 1 commit into from
Aug 20, 2024

Conversation

xuwei-k
Copy link
Member

@xuwei-k xuwei-k commented Aug 20, 2024 

io/src/main/scala/sbt/io/Using.scala:15:8: This wildcard import imports java.io.IO, which is shadowed by sbt.io.IO.
[error] This is not according to the language specification and has changed in Scala 2.13, where java.io.IO takes precedence.
[error] To keep the same meaning in 2.12 and 2.13, un-import IO by adding `IO => _` to the import list.
[error] import java.io._
[error]        ^
[error] one error found
[error] (io / Compile / compileIncremental) Compilation failed

xuwei-k referenced this pull request in scala/community-build Aug 20, 2024
@SethTisue
some projects are expected-to-fail on JDK 23
2c80ef4
eed3si9n
eed3si9n approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit ee6c3e9 into sbt:develop Aug 20, 2024
7 checks passed
@xuwei-k xuwei-k deleted the JDK-23-java-io-IO branch August 20, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xuwei-k @eed3si9n