-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add amazon-corretto base image (21, 17) #207
Conversation
kijuky
commented
Jul 31, 2022
- copy eclipse-temurin dockerfile
- change apt-get -> yum (for amazon linux)
- The base image doesn't even have tar or gzip so I'm running that first.
I wonder at what point github will tell us we have too many builds Are you actively using jdk 8? |
surely.... 8 is erased. |
In many cases, having an LTS is enough. So just 11 and 17. If you ever need 18, make another pull request at that time. |
Looks like the scala 3 docker build is failing on something related to tput in the scala startup script: introduced in scala/scala3#10304 Also found this related thread Might be something to report on the dotty issue tracker |
you could try adding |
I will try it! |
I tried adding this option, but it didn't help. Even if I change the settings or environment variables, tput will always be executed. As a last resort, I renamed tput only when running scala. Doesn't seem like a very good way to do it, but I was out of ideas... 😢 |
1c53138
to
b75d204
Compare
c98e178
to
8c93d71
Compare
Updated to latest 21, 17 |
adding |
1ea3d06
to
da80174
Compare
MEMO
|
d8781da
to
14bc3d9
Compare
Another workaround could be replacing |
Changed to use al2023 instead of default al2. https://docs.aws.amazon.com/linux/al2023/ug/compare-with-al2.html The tput issue has been resolved, but there seems to be another issue. |
https://github.com/sbt/docker-sbt/actions/runs/11838202219/job/32986821395?pr=207#step:8:1585
|
Ah I have seen that before |
That's why the graalvm scala3 builds are excluded. |
73ae3b0
to
f187aee
Compare
@kijuky are we good to go if this builds without issues? |
One thing I was concerned about was the naming of the Dockerfile. Since alpine is named alpine.Dockerfile, is it better to use al2023.Dockerfile as well? |
For my part it can stay the way it is. It's up to you. |
thanks @kijuky |