Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import: add todomovies #618

Merged
merged 5 commits into from
Sep 16, 2024
Merged

Import: add todomovies #618

merged 5 commits into from
Sep 16, 2024

Conversation

AlexPerathoner
Copy link
Contributor

@AlexPerathoner AlexPerathoner commented Sep 3, 2024

Fix #613

Changes made

Added:

  • button in /import for todomovies
  • processing of .todomovieslist files
  • tags are added during import from custom lists

Missing

  • I couldn't get the svg icon to properly work out...

Screenshots

immagine

immagine
(I've left in the column with the status since I had already added it - I think it helps telling immediately that the status is imported, too - let me know if I should I take it out)
immagine

Here's a sample todomovies backup file to test yourself:
TodoMovies_4.17_DB_2024_09_02_20_26_20.todomovieslist.zip

Added:
- button in /import
- process of .todomovieslist files
- tags from import
@AlexPerathoner AlexPerathoner changed the title Import: add todomovies Import: add todomovies (#613) Sep 3, 2024
@AlexPerathoner AlexPerathoner changed the title Import: add todomovies (#613) Import: add todomovies Sep 3, 2024
@IRHM IRHM self-assigned this Sep 5, 2024
@IRHM IRHM added the enhancement New feature or request label Sep 5, 2024
simplified and removed fill so styling can color it
Probably a more famous import option, so moving it a bit higher in the list
and formatted code, updated some logs
…ED option

Status table header was missing, corrected dropdown value from PLANNING to PLANNED
@IRHM
Copy link
Member

IRHM commented Sep 16, 2024

Hey @AlexPerathoner, apologies for taking so long to getting around to merging this. Everything looks great and thank you for getting this done!

I made a few changes (didn't want to make you go back to old code):

  • Fixed the todomovies icon for you, mainly just needed to remove the fill="#fff" and the css took care of the rest (also ran it through svgomg to simplify it).
  • Renamed the getTag function to getTagByNameAndColor. Thought it made sense to name it by what it does in this case, since it likely will only be used by our importer (and don't want to confuse with that commented out getTag code above incase we ever need it).
  • Added the name of tags to error logs, incase we ever encounter any, it should be a little easier for debugging.
  • Added the status heading to the import/process table (for status dropdown column).
  • Fixed status dropdown PLANNED value (was PLANNING).

Thanks again!

@IRHM IRHM merged commit f8e5a66 into sbondCo:dev Sep 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Import of TodoMovies
2 participants