Implement BMP RAW message type #212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous version, if it was ever called with multiple messages in the buffer, the index into the buffer could have been updated incorrectly in a couple of places.
But it compiles. :-)
It is being used when --bmp-raw is in effect.
Also alphabetize remaining options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of BMP RAW messages that can be found in OpenBMP (as described in https://github.com/SNAS/openbmp/blob/master/docs/MESSAGE_BUS_API.md).
Production of the raw messages can be switched on by specifying --bmp-raw on the command line.
Additionally, a --admin-id=STRING option is added in order to have a control over collector hash ID mentioned in the RAW format specification.
Specifying --bmp-raw only makes sense in case Kafka publishing is in effect.
The implementation is fairly straightforward as the producer needs to do less work than in the case of parsed messages produced by default.
This work is based on an E-mail discussion between goBMP's author Serguei Bezverkhi @sbezverk and David Teach @dteach-rv, and was sponsored by NSRC https://nsrc.org/