Plasma UI typecov #1099
Plasma UI typecov #1099
Conversation
|
Demo canvas app deployed! |
Codecov Report
@@ Coverage Diff @@
## master #1099 +/- ##
==========================================
- Coverage 88.14% 86.08% -2.07%
==========================================
Files 341 309 -32
Lines 4489 4046 -443
Branches 1338 1194 -144
==========================================
- Hits 3957 3483 -474
- Misses 531 563 +32
+ Partials 1 0 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Documentation preview deployed! website: http://plasma.sberdevices.ru/pr-1099/ |
|
Demo canvas app deployed! |
|
Documentation preview deployed! website: http://plasma.sberdevices.ru/pr-1099/ |
|
Demo canvas app deployed! |
|
Documentation preview deployed! website: http://plasma.sberdevices.ru/pr-1099/ |
| @@ -160,27 +160,27 @@ export const DatePicker: React.FC<DatePickerProps> = ({ | |||
| ); | |||
|
|
|||
| const onYearChange = React.useCallback( | |||
| ({ value: y }) => { | |||
| ({ value: y }: PickerItem) => { | |||
There was a problem hiding this comment.
мне кажется надо либо тип PickerItem как-то сузить, либо
({ value: y }: {value: number})
вместо явного приведения через as
| }); | ||
| }, | ||
| [getNextDay, getNextMonth], | ||
| ); | ||
| const onMonthChange = React.useCallback( | ||
| ({ value: m }) => { | ||
| ({ value: m }: PickerItem) => { |
There was a problem hiding this comment.
тот же коммент, что и выше
| [], | ||
| ); | ||
| const onSecondsChange = React.useCallback( | ||
| ({ value: s }: PickerItem) => setState(([h, m]) => [h, m, s as number]), |
There was a problem hiding this comment.
раз это много где повторяется, мб заведем новый тип TimePickerItem в types?
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @sberdevices/demo-canvas-app@0.60.0-canary.1099.86a7bb4fb5e97b43bafe6743c81d7e8c74413928.0 npm install @sberdevices/plasma-temple@1.32.0-canary.1099.86a7bb4fb5e97b43bafe6743c81d7e8c74413928.0 npm install @sberdevices/plasma-ui@1.83.0-canary.1099.86a7bb4fb5e97b43bafe6743c81d7e8c74413928.0 npm install @sberdevices/showcase@0.98.0-canary.1099.86a7bb4fb5e97b43bafe6743c81d7e8c74413928.0 npm install @sberdevices/plasma-ui-docs@0.44.0-canary.1099.86a7bb4fb5e97b43bafe6743c81d7e8c74413928.0 # or yarn add @sberdevices/demo-canvas-app@0.60.0-canary.1099.86a7bb4fb5e97b43bafe6743c81d7e8c74413928.0 yarn add @sberdevices/plasma-temple@1.32.0-canary.1099.86a7bb4fb5e97b43bafe6743c81d7e8c74413928.0 yarn add @sberdevices/plasma-ui@1.83.0-canary.1099.86a7bb4fb5e97b43bafe6743c81d7e8c74413928.0 yarn add @sberdevices/showcase@0.98.0-canary.1099.86a7bb4fb5e97b43bafe6743c81d7e8c74413928.0 yarn add @sberdevices/plasma-ui-docs@0.44.0-canary.1099.86a7bb4fb5e97b43bafe6743c81d7e8c74413928.0