Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use dict[str, Any] for validated_data #49

Merged
merged 4 commits into from
Sep 14, 2024

Conversation

last-partizan
Copy link

TODO(sbdchd): figure out how hard it would be to make this return a dict[str, Any]

Turned out not hard at all ;)

sbdchd
sbdchd previously approved these changes Apr 27, 2024
rest_framework-stubs/serializers.pyi Outdated Show resolved Hide resolved
@sbdchd sbdchd dismissed their stale review April 27, 2024 14:29

Meant to comment

@last-partizan
Copy link
Author

@sbdchd Hi, can we merge this?

Btw, do you still use/maintain this project? Maybe i should just use my own fork ...

@kodiakhq kodiakhq bot merged commit 5bf5fbb into sbdchd:master Sep 14, 2024
2 checks passed
@sbdchd
Copy link
Owner

sbdchd commented Sep 14, 2024

tbh I don't use Django rest framework anymore but I'll merge PRs and stuff for this

@last-partizan last-partizan deleted the validate-dict branch September 14, 2024 14:42
@last-partizan
Copy link
Author

Can I do single PR with all my latest changes, so you don't have to review batch of small PR's separately?

No big changes, some maintenance stuff (like updating ruff and replacing black with ruff format), and some fixes.

https://github.com/sbdchd/djangorestframework-types/compare/master...last-partizan:djangorestframework-types:master?expand=1

@sbdchd
Copy link
Owner

sbdchd commented Sep 14, 2024

works for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants