refactor: add frame info duration loop that checks the number of image info to add #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that if the current frame contains the same image info, they are only considered as one frame which makes the actual gif unable to play the complete gif frame/duration.
To make things clear, here's an example gif:
The first( image with #1) frame's duration is 4 seconds but when played, it only shows 1 frame since they're all the same. Then the rest is fine since they're all playing at 1 sec, meaning 1 frame.
So to fix that, I added a validator that loop and checks whether the actual duration/frame was added to the list of
ImageInfo
s.Another thing, I replaced this deprecated method:
'instantiateImageCodec' is deprecated and shouldn't be used. Use instantiateImageCodecFromBuffer with an ImmutableBuffer instance instead. This feature was deprecated after v2.13.0-1.0.pre..
by using the suggested: