-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup + Easy color changing #48
Conversation
…test support libs and androidx, enabled support vector and some code cleanup
You can try it before this gets merged: Change the dependency:https://jitpack.io/#alashow/DateRangePicker/1.3.1: dependencies {
implementation 'com.github.alashow:DateRangePicker:1.3.1'
} Override the colors <color name="calendar_selected_day_bg">@color/primary</color>
<color name="calendar_selected_range_bg">@color/primary</color>
<color name="dateTimeRangePickerStateToday">@color/primary</color> |
now actually resolves savvisingh#39
@alashow In https://github.com/alashow/DateRangePicker you write that we can import your fork library with:
But that is a path to the original library. After adding After removing an imported library
I got many errors in
So I have to reference all views from XML in Kotlin with |
Yes, I didn't update readme files in this fork.
I didn't change
Yes, as I upgraded to latest support libs. Did you upgrade your project to AndroidX? As far as I know, you can't use a library with AndroidX if you aren't using AndroidX (Jetifier only works the other way). |
Sorry, you are right, you didn't change to 15. When I imported DateRangePicker last year, I manually changed to 14. Currently I don't know whether I should upgrade the project to AndroidX. It works without it. |
Well, you will have to upgrade in the near future as most libraries started upgrading to it. |
I read that 28.0.0 would be the last version of support-libraries, so, you are right, I have to upgrade to AndroidX. Probably it will waste several hours for me. Not only migration, but also testing. |
Thanks will review the code this coming weekend |
@savvisingh this can be improved though: overriding colors via attributes per view and not globally via resources. |
Yeah that is the ideal approach but for now, I have published the new version with overriding the color values from resource file |
how to change the text of date selected? |
targetAPI
colors.xml
will work.android:tint
in vector resources for color overriding.