Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/constant uppercase #1850

Closed
wants to merge 5 commits into from
Closed

Conversation

diphtongue
Copy link
Contributor

@diphtongue diphtongue commented Dec 8, 2023

What's done:

  • Added configuration to diktat-analysis-huawei.yml

diphtongue and others added 4 commits December 8, 2023 11:33
- Fixed `serialVersionUID`, which should be ignored in `CONSTANT_UPPERCASE`
- Added warning test

Closes #1847
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bb23743) 78.44% compared to head (c732b1b) 78.44%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1850   +/-   ##
=========================================
  Coverage     78.44%   78.44%           
  Complexity     2455     2455           
=========================================
  Files           133      133           
  Lines          8644     8644           
  Branches       2184     2184           
=========================================
  Hits           6781     6781           
  Misses          896      896           
  Partials        967      967           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 8, 2023

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   8m 9s ⏱️ + 3m 13s
1 413 tests ±0  1 377 ✔️ ±0  36 💤 ±0  0 ±0 
2 792 runs  ±0  2 756 ✔️ ±0  36 💤 ±0  0 ±0 

Results for commit c732b1b. ± Comparison against base commit bb23743.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 8, 2023

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   7m 22s ⏱️ +12s
1 413 tests ±0  1 396 ✔️ ±0  17 💤 ±0  0 ±0 
2 792 runs  ±0  2 775 ✔️ ±0  17 💤 ±0  0 ±0 

Results for commit c732b1b. ± Comparison against base commit bb23743.

♻️ This comment has been updated with latest results.

@diphtongue diphtongue marked this pull request as ready for review December 12, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants