Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated smoke test to diktat cli #1782

Merged
merged 5 commits into from
Nov 8, 2023
Merged

Migrated smoke test to diktat cli #1782

merged 5 commits into from
Nov 8, 2023

Conversation

nulls
Copy link
Member

@nulls nulls commented Nov 7, 2023

What's done:

  • moved smoke tests from diktat-ruleset to diktat-cli

It closes #1781

@nulls
Migrated smoke test to diktat cli
71a8c4b 
### What's done:
- moved smoke tests from `diktat-ruleset` to `diktat-cli`

It closes #1781
@nulls nulls self-assigned this Nov 7, 2023
@nulls nulls added the tests Improve testing label Nov 7, 2023
@nulls nulls added this to the 2.0.0 milestone Nov 7, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 7, 2023 •
edited
Loading

Codecov Report

Merging #1782 (5280a97) into master (d981125) will increase coverage by 0.43%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1782      +/-   ##
============================================
+ Coverage     77.99%   78.42%   +0.43%     
  Complexity     2415     2415              
============================================
  Files           127      126       -1     
  Lines          8511     8464      -47     
  Branches       2152     2147       -5     
============================================
  Hits           6638     6638              
+ Misses          914      867      -47     
  Partials        959      959

see 1 file with indirect coverage changes

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023 •
edited
Loading

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   5m 44s ⏱️ -4s
1 389 tests ±0  1 353 ✔️ ±0  36 💤 ±0  0 ❌ ±0 
2 768 runs  ±0  2 732 ✔️ ±0  36 💤 ±0  0 ❌ ±0 

Results for commit 5280a97. ± Comparison against base commit d981125.

This pull request removes 38 and adds 38 tests. Note that renamed tests count towards both. 
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ disable chapters()
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ fix can cause long line()
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ regression - FP of local variables rule()
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ regression - should correctly handle tags with empty lines()
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ regression - should not fail if package is not set()
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ regression - shouldn't throw exception in cases similar to #371()
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ smoke test #1()
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ smoke test #2()
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ smoke test #3()
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ smoke test #4()
…

com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ disable chapters()
com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ fix can cause long line()
com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ regression - FP of local variables rule()
com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ regression - should correctly handle tags with empty lines()
com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ regression - should not fail if package is not set()
com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ regression - shouldn't throw exception in cases similar to #371()
com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ smoke test #1()
com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ smoke test #2()
com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ smoke test #3()
com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ smoke test #4()
…
This pull request removes 19 skipped tests and adds 19 skipped tests. Note that renamed tests count towards both. 
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ disable chapters()
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ fix can cause long line()
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ regression - FP of local variables rule()
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ regression - should correctly handle tags with empty lines()
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ regression - should not fail if package is not set()
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ regression - shouldn't throw exception in cases similar to #371()
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ smoke test #1()
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ smoke test #2()
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ smoke test #3()
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ smoke test #4()
…

com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ disable chapters()
com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ fix can cause long line()
com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ regression - FP of local variables rule()
com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ regression - should correctly handle tags with empty lines()
com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ regression - should not fail if package is not set()
com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ regression - shouldn't throw exception in cases similar to #371()
com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ smoke test #1()
com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ smoke test #2()
com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ smoke test #3()
com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ smoke test #4()
…

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023 •
edited
Loading

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   8m 57s ⏱️ -57s
1 389 tests ±0  1 372 ✔️ ±0  17 💤 ±0  0 ❌ ±0 
2 768 runs  ±0  2 751 ✔️ ±0  17 💤 ±0  0 ❌ ±0 

Results for commit 5280a97. ± Comparison against base commit d981125.

This pull request removes 38 and adds 38 tests. Note that renamed tests count towards both. 
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ disable chapters()
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ fix can cause long line()
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ regression - FP of local variables rule()
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ regression - should correctly handle tags with empty lines()
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ regression - should not fail if package is not set()
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ regression - shouldn't throw exception in cases similar to #371()
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ smoke test #1()
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ smoke test #2()
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ smoke test #3()
com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ smoke test #4()
…

com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ disable chapters()
com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ fix can cause long line()
com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ regression - FP of local variables rule()
com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ regression - should correctly handle tags with empty lines()
com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ regression - should not fail if package is not set()
com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ regression - shouldn't throw exception in cases similar to #371()
com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ smoke test #1()
com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ smoke test #2()
com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ smoke test #3()
com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ smoke test #4()
…

♻️ This comment has been updated with latest results.

@nulls nulls marked this pull request as ready for review November 8, 2023 09:15
@nulls nulls merged commit 6c04a7a into master Nov 8, 2023
33 checks passed
@nulls nulls deleted the feature/run-diktat-cli-smoke-test#1781 branch November 8, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x6675636b796f75676974687562 0x6675636b796f75676974687562 0x6675636b796f75676974687562 approved these changes

@kgevorkyan kgevorkyan Awaiting requested review from kgevorkyan

@orchestr7 orchestr7 Awaiting requested review from orchestr7

Assignees

@nulls nulls

Labels
tests Improve testing
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Remove ktlint from running smoke tests
2 participants
@nulls @0x6675636b796f75676974687562