Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed BracesInConditionalsAndLoopsRule #1745

Closed
wants to merge 10 commits into from
Closed

Conversation

nulls
Copy link
Member

@nulls nulls commented Sep 22, 2023

What's done:

  • creating BLOCK section in THEN section
  • reused ASTFactory

It's part of #1737

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #1745 (990e609) into master (eb6ef05) will increase coverage by 0.49%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1745      +/-   ##
============================================
+ Coverage     76.02%   76.51%   +0.49%     
- Complexity     2281     2291      +10     
============================================
  Files           126      126              
  Lines          8242     8258      +16     
  Branches       2069     2070       +1     
============================================
+ Hits           6266     6319      +53     
+ Misses         1060     1027      -33     
+ Partials        916      912       -4     
Files Changed Coverage Δ
...rules/chapter3/BracesInConditionalsAndLoopsRule.kt 93.33% <100.00%> (+36.60%) ⬆️

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   5m 33s ⏱️ -18s
1 378 tests ±0  1 319 ✔️ +2  59 💤  - 2  0 ±0 
2 757 runs  ±0  2 697 ✔️ +2  60 💤  - 2  0 ±0 

Results for commit 990e609. ± Comparison against base commit eb6ef05.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   6m 58s ⏱️ + 1m 4s
1 378 tests ±0  1 331 ✔️ +2  47 💤  - 2  0 ±0 
2 757 runs  ±0  2 709 ✔️ +2  48 💤  - 2  0 ±0 

Results for commit 990e609. ± Comparison against base commit eb6ef05.

♻️ This comment has been updated with latest results.

@nulls nulls self-assigned this Sep 25, 2023
@nulls nulls added the tests Improve testing label Sep 25, 2023
@nulls nulls added this to the 2.0.0 milestone Sep 25, 2023
@nulls nulls closed this Sep 25, 2023
@nulls nulls deleted the feature/fix-tests#1737 branch September 25, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Improve testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant