Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CommentsFormatting for else blocks #1743

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Conversation

nulls
Copy link
Member

@nulls nulls commented Sep 21, 2023

What's done:

  • removed a removing of moved ASTNode
  • reused ASTFactory

It's part of #1737

### What's done:
- removed a removing of moved ASTNode
- reused ASTFactory

It's part of #1737
@nulls nulls added bug Something isn't working tests Improve testing labels Sep 21, 2023
@nulls nulls added this to the 2.0.0 milestone Sep 21, 2023
@nulls nulls self-assigned this Sep 21, 2023
@nulls nulls enabled auto-merge (squash) September 21, 2023 12:55
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #1743 (2d03fa2) into master (05e7aa4) will increase coverage by 0.44%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1743      +/-   ##
============================================
+ Coverage     75.49%   75.94%   +0.44%     
- Complexity     2277     2282       +5     
============================================
  Files           126      126              
  Lines          8236     8234       -2     
  Branches       2068     2068              
============================================
+ Hits           6218     6253      +35     
+ Misses         1103     1063      -40     
- Partials        915      918       +3     
Files Changed Coverage Δ
.../ruleset/rules/chapter2/kdoc/CommentsFormatting.kt 71.00% <100.00%> (+18.02%) ⬆️

@github-actions
Copy link
Contributor

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files     164 suites   6m 25s ⏱️
1 378 tests 1 314 ✔️ 64 💤 0
2 757 runs  2 692 ✔️ 65 💤 0

Results for commit 2d03fa2.

@github-actions
Copy link
Contributor

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   5m 47s ⏱️ -46s
1 378 tests ±0  1 326 ✔️ +1  52 💤  - 1  0 ±0 
2 757 runs  ±0  2 704 ✔️ +1  53 💤  - 1  0 ±0 

Results for commit 2d03fa2. ± Comparison against base commit 05e7aa4.

@nulls nulls merged commit feeeee9 into master Sep 21, 2023
33 checks passed
@nulls nulls deleted the feature/fix-tests#1737 branch September 21, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests Improve testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants