NO_BRACES_IN_CONDITIONALS_AND_LOOPS fail within variable initialization block #1739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Provide fix * Add test Closes saveourtool#1270
Codecov Report
@@ Coverage Diff @@
## master #1739 +/- ##
============================================
+ Coverage 76.02% 76.10% +0.07%
- Complexity 2281 2283 +2
============================================
Files 126 126
Lines 8242 8243 +1
Branches 2069 2070 +1
============================================
+ Hits 6266 6273 +7
+ Misses 1060 1050 -10
- Partials 916 920 +4
|
nulls
approved these changes
Sep 20, 2023
…e function ### What's done: * added findIndentBeforeNode() function * reworked test for loops * added test for conditions
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ain/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/BracesInConditionalsAndLoopsRule.kt
Fixed
Show resolved
Hide resolved
nulls
reviewed
Sep 22, 2023
...ain/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/BracesInConditionalsAndLoopsRule.kt
Outdated
Show resolved
Hide resolved
nulls
reviewed
Sep 22, 2023
...ain/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/BracesInConditionalsAndLoopsRule.kt
Outdated
Show resolved
Hide resolved
* fixed indent handling by using safe call for case when `if` comes after bracket * fixed indent handling for `else if` case * added test for `else if` case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
Closes #1270