Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Sauce Connect 5 #293

Merged
merged 10 commits into from
Oct 24, 2024
Merged

Update to Sauce Connect 5 #293

merged 10 commits into from
Oct 24, 2024

Conversation

alexh-sauce
Copy link
Contributor

@alexh-sauce alexh-sauce commented Oct 4, 2024 •
edited
Loading

Update SC client binaries to Sauce Connect 5

  • Update the CLI options.
  • Use HTTP API checks instead of parsing log files.
  • Bump version to 2.0 as these are breaking API changes, and will also require the user to change their custom CLI options.

Fixes #254

@alexh-sauce alexh-sauce force-pushed the alexh-use-sc-5 branch 2 times, most recently from 822a580 to accc660 Compare October 4, 2024 20:49
@alexh-sauce alexh-sauce force-pushed the alexh-use-sc-5 branch 3 times, most recently from 06a6fb8 to f5e52a6 Compare October 21, 2024 17:04
@mmatczuk
Copy link

I wonder why not use 5.2.0.

mmatczuk
mmatczuk reviewed Oct 23, 2024
View reviewed changes
README.md Show resolved Hide resolved
@alexh-sauce alexh-sauce force-pushed the alexh-use-sc-5 branch 2 times, most recently from 8dd0218 to 35a04aa Compare October 23, 2024 21:21
@mmatczuk
Copy link

LGTM. I did not run it.

@mmatczuk mmatczuk self-requested a review October 24, 2024 09:41
@alexh-sauce alexh-sauce merged commit 58d7c6a into main Oct 24, 2024
3 checks passed
@alexh-sauce alexh-sauce deleted the alexh-use-sc-5 branch October 24, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmatczuk mmatczuk mmatczuk approved these changes

@diemol diemol Awaiting requested review from diemol

@budziam budziam Awaiting requested review from budziam

@amckenzie132 amckenzie132 Awaiting requested review from amckenzie132

@Choraden Choraden Awaiting requested review from Choraden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support of SauceConnect 5
2 participants
@alexh-sauce @mmatczuk