Document the moz-document breaking change on the sass website. #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goodwine
requested changes
Sep 6, 2022
| --- | ||
|
|
||
| Sass has historically supported a special parsing for the `@-moz-document` rule. | ||
| As [Firefox dropped support for them], Sass will also drop support. |
There was a problem hiding this comment.
Per this comment - sass/dart-sass#378 (comment)
Sass won't drop support entirely, only for the special parsing in favor of interpolation within unknown at-rules
stof
force-pushed
the
moz_document_rule
branch
2 times, most recently
from
42c7281
to
d89ab68
Compare
stof
force-pushed
the
moz_document_rule
branch
from
d89ab68
to
5f3180e
Compare
|
@Goodwine updated |
Goodwine
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the link in the deprecation warning goes to a website that does not even exist anymore, relying on the web-archive. And this website does not give any details about the Sass breaking change.
This references this breaking change on the website like the others (still linking to the Firefox deprecation announcement on web-archive as part of the explanation).