Deprecate bogus combinators #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
force-pushed
the
complex-component
branch
4 times, most recently
from
44a8ea2
to
015599a
Compare
jathak
approved these changes
Jul 15, 2022
| const AnySelectorVisitor(); | ||
|
|
||
| bool visitComplexSelector(ComplexSelector complex) => complex.components | ||
| .any((component) => visitCompoundSelector(component.selector)); |
There was a problem hiding this comment.
Is there a reason why this calls visitCompoundSelector directly instead of component.selector.accept(this)?
There was a problem hiding this comment.
It just avoids an unnecessary layer of calls, especially since highly polymorphic calls like accept() tend to be particularly difficult for JIT VMs to optimize.
| dependency_overrides: | ||
| source_span: | ||
| git: | ||
| url: https://github.com/dart-lang/source_span |
There was a problem hiding this comment.
Should this PR also be marked as blocked on dart-lang/source_span#86?
There was a problem hiding this comment.
We can't release with a Git dependency, but it's fine to have one for -dev versions.
8 tasks
stof
reviewed
Jul 26, 2022
| var selector = pseudo.selector; | ||
| if (selector == null) return false; | ||
|
|
||
| // The CSS spec specifically allows leading combinators in `:has()`. |
There was a problem hiding this comment.
The CSS spec allows 1 leading combinator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sass/sass#3340
See #1727
See sass/sass-spec#1803
Blocked on #1741