Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split workflow & task logs, add state and update time to task logs #427

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

essweine
Copy link
Contributor

@essweine essweine commented Jul 16, 2024

This PR splits the spitt logger into task and worklfow logs and standardized attributes on both.

Attributes available for tasks:

  • workflow_spec: the name of the workflow spec
  • task_spec: the name of the task spec
  • task_id: the task id
  • task_type: a string representation of the tasks's class
  • state: the name of the task's state
  • last_state_change: the update timestamp

If the logging level is < 20 (below INFO)

  • data: the task data
  • internal_data: the task's internal data

Attributes available for workflows:

  • workflow_spec: the spec name
  • success: the value of the success attribute
  • completed: the value of the completed attribute

If the logging level is < 20:

  • tasks: a list of the task ids

The spiff.metrics logger has been removed.

@essweine essweine requested a review from jbirddog July 16, 2024 19:09
@essweine essweine merged commit 14c84aa into main Jul 25, 2024
5 checks passed
@essweine essweine deleted the feature/improved-loggers branch July 25, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants