[VSC] Sessions (2/3) #956
Draft
[VSC] Sessions (2/3) #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschaefer88
force-pushed
the
pr/vscode/sessions
branch
from
9e2b21a
to
af792c2
Compare
The Saros implementation will be based on the Language Server Protocol (see https://microsoft.github.io/language-server-protocol) for data exchange. In order to enable VS Code to understand that protocol the VS Code language client has been added. Furthermore starting of the Saros LSP Server has been encapsulated.
Unintentionally removed parts have been readded (lsp) and code has been improved regarding guidelines. Overall quality has been improved. Vscodes extension build, run and publish workflow has been shifted from npm based to gradle base to embed it better into the gradle environment and to enable easier CI builds.
In order to keep the size of the extension rather small the building method has been changed to webpack. This also brings the benefit of excluding files that aren't really needed.
Introduce eslint and modify code accordingly. Furthermore gradle has been modified in order to seperate config and execute statements.
This commit will add the functionality of managing accounts and contacts of Saros. There are wizards for handling those data and necessary UI elements such as the contact and active account view.
This commit will add the functionality of managing accounts and contacts of Saros. Basic functionality like logging and config exchange is also implemented. All classes that will contain logic of Saros from a later stage will be mostly empty.
mschaefer88
force-pushed
the
pr/vscode/sessions
branch
from
af792c2
to
eeb7b1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is the second of three to completely integrate the current state of "Saros for VS Code" into Saros.
This pull request contains all implementations regarding session management.