Set up initial code #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSuperiorStanislav
requested review from
MrShirokow and
LeonidMalin
as code owners
LeonidMalin
approved these changes
Mar 25, 2024
TheSuperiorStanislav
force-pushed
the
feature/add-code
branch
2 times, most recently
from
18ab702 to
467d7e1
Compare
MrShirokow
approved these changes
Mar 25, 2024
Comment on lines
+27
to
+30
| class SqlAlchemyInteractorHooksMixin( | ||
| interactors.BaseHooksMixin[saritasa_sqlalchemy_tools.BaseModelT], | ||
| ): | ||
| """Hooks for sqlalchemy.""" |
There was a problem hiding this comment.
This class is really needed? Why not just use BaseHooksMixin?
There was a problem hiding this comment.
Just to specify that it work with models from sqlachemy-tools(for now it's maybe no difference, but it future it will make it easier to spot changes for devs).
TheSuperiorStanislav
force-pushed
the
feature/add-code
branch
from
467d7e1 to
5cf73ff
Compare
Co-authored-by: Shirokov Sergey <[email protected]> Co-authored-by: Leonid Malin <[email protected]> Co-authored-by: Roman Gorbil <[email protected]>
TheSuperiorStanislav
force-pushed
the
feature/add-code
branch
from
5cf73ff to
d1df0b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.