Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/jc 672 authorization #5

Open
wants to merge 64 commits into
base: develop
Choose a base branch
from
Open

Feature/jc 672 authorization #5

wants to merge 64 commits into from

Conversation

AngelinaShmantsar
Copy link
Contributor

No description provided.

@AngelinaShmantsar
Add auth form layout JC-672
f49b2ee
@AngelinaShmantsar
Add form changing by button click JC-672
9490f5d
@AngelinaShmantsar
Add control flow for form fields, make form height fit content JC-672
4aabffe
@AngelinaShmantsar
Remove app header from auth page JC-672
ed77533
@AngelinaShmantsar
Add auth service, dto, models and mapper, fix problem with form change …
7dbd3ad 
…JC-672
@AngelinaShmantsar
Add interceptor for auth tokens, install cookie service package JC-672
094739a
@AngelinaShmantsar
Add redirect to main page after authorization JC-672
b92a79d
@AngelinaShmantsar
Add password identity validator JC-672
623cb21
@AngelinaShmantsar
Add validators and error messages JC-672
ba83d9e
@AngelinaShmantsar
Add token refreshing logic JC-672
23092dd
@AngelinaShmantsar
Add logout logic JC-672
c40a3af
@AngelinaShmantsar
Add async validator draft JC-672
353e5f5
@AngelinaShmantsar
Add CSS variables JC-672
b55d98f
@AngelinaShmantsar
Move complex conditions from template JC-672
d1e8deb
@AngelinaShmantsar
Move validators to service JC-672
dc9b857
@AngelinaShmantsar
Add backend errors handling and validation JC-672
3604ecd
@AngelinaShmantsar
Remove error message after input value change JC-672
4dcd2bf
@AngelinaShmantsar
Move form management to separate service JC-672
7888652
@AngelinaShmantsar
Fix some comments JC-672
35f199a
@AngelinaShmantsar
Move authorization entities to auth folder JC-672
a5b3c82
@AngelinaShmantsar
Add lazy loading JC-672
4339246
@AngelinaShmantsar
Fix subscription management JC-672
1cede28
@AngelinaShmantsar
Move auth service to core JC-672
acdc7c7
@AngelinaShmantsar
Move auth forms to separate components JC-672
ac6ad5d
@AngelinaShmantsar
Add form builder JC-672
5616467
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

PR Preview Action v1.4.7
🚀 Deployed preview to https://saritasa-nest.github.io/camp-js-2024-angelina-shmantsar/pr-preview/pr-5/
on branch gh-pages at 2024-08-26 06:26 UTC

@AngelinaShmantsar AngelinaShmantsar changed the base branch from develop to feature/JC-653-anime-list-management August 5, 2024 11:45
@AngelinaShmantsar AngelinaShmantsar requested a review from a team August 5, 2024 12:06
andrey-gazzaev
andrey-gazzaev requested changes Aug 9, 2024
View reviewed changes
apps/angular/src/app/features/auth/components/error/error.component.ts Outdated Show resolved Hide resolved
apps/angular/src/app/features/auth/components/login-form/login-form.component.html Outdated Show resolved Hide resolved
apps/angular/src/app/features/auth/components/login-form/login-form.component.ts Outdated Show resolved Hide resolved
apps/angular/src/app/features/auth/components/login-form/login-form.component.ts Outdated Show resolved Hide resolved
.../angular/src/app/features/auth/components/registration-form/registration-form.component.html Outdated Show resolved Hide resolved
apps/angular/src/core/services/api-url.service.ts Outdated Show resolved Hide resolved
apps/angular/src/core/services/auth.service.ts Outdated Show resolved Hide resolved
apps/angular/src/core/services/local-storage.service.ts Outdated Show resolved Hide resolved
apps/angular/src/core/services/navigation.service.ts Outdated Show resolved Hide resolved
apps/angular/src/core/services/validation.service.ts Show resolved Hide resolved
@AngelinaShmantsar
Merge branch 'feature/JC-653-anime-list-management' into feature/JC-6…
367aac7 
…72-authorization
@AngelinaShmantsar
Fix linter problems JC-672
4410842
@AngelinaShmantsar
Fix control styles JC-672
ab8f7be
@AngelinaShmantsar
Add setter for error message JC-672
aef5afa
@AngelinaShmantsar
Separate login and register pages JC-672
92019d6
@AngelinaShmantsar
Move server error type determination to validation service JC-672
89429c5
@AngelinaShmantsar
Add the ability to see password JC-672
d693669
@AngelinaShmantsar
Fix form creation and naming in comments JC-672
5e692ce
@AngelinaShmantsar
Rename local storage service, save auth tokens as single data structure
97f6a59 
JC-672
@AngelinaShmantsar
Remove condition control flow for errors JC-672
6f9909f
@AngelinaShmantsar
Fix some comments JC-672
2fdc389
@AngelinaShmantsar
Try to fix SonarCloud error JC-672
9a3c4de
@AngelinaShmantsar
Try to fix SonarCloud error again JC-672
4fc67f6
@AngelinaShmantsar
Try to fix SonarCloud error again JC-672
25fbdd0
@AngelinaShmantsar
Make default page size and default page number constants JC-672
6057ac5
andrey-gazzaev
andrey-gazzaev approved these changes Aug 18, 2024
View reviewed changes
libs/core/models/register-credentials.ts
readonly password: string;

/** Avatar image url. */
readonly avatarUrl?: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
readonly avatarUrl?: string;
readonly avatarUrl: string | null;

It is preferable to work with explicit values

Base automatically changed from feature/JC-653-anime-list-management to develop August 23, 2024 04:30
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pavelzadorin-saritasa pavelzadorin-saritasa removed the request for review from EgorRyazanov September 3, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelzadorin-saritasa pavelzadorin-saritasa pavelzadorin-saritasa left review comments

@andrey-gazzaev andrey-gazzaev andrey-gazzaev approved these changes

@TienLuu-Saritasa TienLuu-Saritasa Awaiting requested review from TienLuu-Saritasa TienLuu-Saritasa was automatically assigned from saritasa-nest/saritasa-frontend

@maxineo maxineo Awaiting requested review from maxineo

@gevorg-gevorgyan-saritasa gevorg-gevorgyan-saritasa Awaiting requested review from gevorg-gevorgyan-saritasa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AngelinaShmantsar @pavelzadorin-saritasa @gevorg-gevorgyan-saritasa @maxineo @andrey-gazzaev