Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved division to ComplexField and implemented Div for missing types. #150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Moved division to ComplexField and implemented Div for missing types. #150

wants to merge 1 commit into from

Conversation

TileHalo
Copy link

@TileHalo TileHalo commented Sep 3, 2024

More specificially, implemented Div<Scale<RhsE>> for Scale<LhsE> and similarly DivAssign.

Closes #149 .

@TileHalo
Moved division to ComplexField and implemented Div for missing types.
5234795 
More specificially, implemented Div(Assign)<Scale<RhsE>> for
Scale<LhsE>.
@sarah-quinones
Copy link
Owner

we don't really want the faer_div function. could you replace x.faer_div(y) with x * y.faer_inv()?

@TileHalo
Copy link
Author

TileHalo commented Sep 7, 2024 •
edited
Loading

Sure, will do.

Edit: I guess the faer_div in RealField should be retained?

@sarah-quinones
Copy link
Owner

yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Div and DivAssign is missing from some types (ComplexField and Scale<Rhs> with itself)
2 participants
@TileHalo @sarah-quinones