Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event propagation to avoid clicking on favorite #8

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

saracrz
Copy link
Owner

@saracrz saracrz commented Nov 13, 2023

Feature description

The card should be clickable in order to be opened except when clicking on the Star icon.

Summary changes

  • Add event stop propagation to toggleFavorite function.

@saracrz saracrz self-assigned this Nov 13, 2023
@saracrz saracrz merged commit 66aaf8e into main Nov 13, 2023
3 checks passed
Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for dashboards-data ready!

Name Link
🔨 Latest commit eaecc6e
🔍 Latest deploy log https://app.netlify.com/sites/dashboards-data/deploys/655208755e6001000817ce46
😎 Deploy Preview https://deploy-preview-8--dashboards-data.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant