barbican fallback to legacy only if not found #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print actual error when we failed to load pkcs12 cert and falling back to the default implemntation, as exception may not be related to certificate or its format like an issue with wrong methods during cryptography version mismatch *** AttributeError: module 'OpenSSL.crypto' has no attribute 'load_pkcs12' Related-Prod: PRODX-39931 Change-Id: I85c8a615c4f2e08e28939805ae0e9b2028dadaed
velp
approved these changes
Jun 7, 2024
BenjaminLudwigSAP
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Thx.
This is in conjunction with sapcc/octavia-f5-provider-driver#271
BenjaminLudwigSAP
deleted the
barbican-fallback-to-legacy-only-if-not-found
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of the upstream barbican cert mechanism.
The code used to try first to fetch the certificate as a barbican pkcs12 secret,
and if any exception happened to try fetch the certifcate from a barbican container.
The octavia-f5-driver used the 404 message as a hint that the cert was missing or expired. But this
was shadowed by any connection error that the pkcs12 barbican code was encountered, even if there
is a valid pkcs12 certificate.
This change will do the fallback to legacy containers only if the pkcs12 retrieval fails with 404 (not found).
Therefor, octavia-f5-driver can correctly act on a missing certificate