Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Untagged infra networks #140

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Untagged infra networks #140

merged 1 commit into from
Apr 29, 2024

Conversation

sebageek
Copy link
Collaborator

No description provided.

@sebageek
Support untagged infra networks
25474e2 
We now support the already present untagged flag for infra networks.
Only one network can be set as untagged for each hostgroup. As we want
to make sure servers stay deployable via OpenStack, the OpenStack
network will take precedence over an untagged infra network for all
direct mode bindings. Due to this quirk, we also cannot properly sync
the native vlan via the sync_infra_networks API call, so this will have
to be done via a full switch sync.
@sebageek sebageek changed the title WIP: untagged infra networks Untagged infra networks Apr 29, 2024
@sebageek sebageek marked this pull request as ready for review April 29, 2024 11:08
sven-rosenzweig
sven-rosenzweig approved these changes Apr 29, 2024
View reviewed changes
Copy link

@sven-rosenzweig sven-rosenzweig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me. we could think about testing if add_infra_networks_from_hostgroup(self, hg_config, sg, process_untagged=False) is called with correct parameters.

mutax
mutax approved these changes Apr 29, 2024
View reviewed changes
Copy link

@mutax mutax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, seagull and herring approved

@sebageek sebageek merged commit acf44a7 into stable/yoga-m3 Apr 29, 2024
3 checks passed
@sebageek sebageek deleted the set-infra-net-as-native branch April 29, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sven-rosenzweig sven-rosenzweig sven-rosenzweig approved these changes

@defo89 defo89 defo89 approved these changes

@mutax mutax mutax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebageek @mutax @defo89 @sven-rosenzweig