[config-gen] Add interface speed from netbox #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebageek
reviewed
Dec 12, 2023
Comment on lines
243
to
244
| raise ConfigException(f'Interface {iface.id} has a different speed than other ' | ||
| f'member interface(s) of LAG {lag.id}, has {speed}, other(s) have ' | ||
| f'{cls.lag_member_speed_cache[lag.id]}') # type: ignore |
There was a problem hiding this comment.
Is lag.id enough to identify the port channel or would it be easier to the user to have a devicename (or switchport) + port name to find the offending entity?
There was a problem hiding this comment.
I mean lag.id is the primary key in the database table and netbox won't create any duplicate (device_name, interface_name). I wouldn't see a reason to use anything else.
There was a problem hiding this comment.
I was just thinking about the error message displayed to the user. Using lag.id as dict key totally makes sense to me.
swagner-de
force-pushed
the
add-interface-speed
branch
from
dbfb755
to
0f9f8b7
Compare
sebageek
previously approved these changes
Dec 12, 2023
We need to force the speed on some breakout/QSA interfaces. As port-channel members are just plain strings, we add the speed to the port-channel interfaces itself. That is fine, as members can only be of the same speed anyway. For physical interfaces, we can annotate it straight to the interface.
swagner-de
force-pushed
the
add-interface-speed
branch
from
0f9f8b7
to
1d254a4
Compare
sebageek
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to force the speed on some breakout/QSA interfaces. As
port-channel members are just plain strings, we add the speed to the
port-channel interfaces itself. That is fine, as members can only be of
the same speed anyway. For physical interfaces, we can annotate it
straight to the interface.