Netbox 3.0 adjustments #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swagner-de
force-pushed
the
netbox3
branch
2 times, most recently
from
ef0a7a9
to
77c5d50
Compare
sebageek
reviewed
Oct 30, 2023
With netbox 3.0, there were 2 API changes that affect us: 1. Interfaces can now carry multiple connections, I believe is that is to support broken out interfaces. We do not plan to have break outs in the future, however we have them now. Yet we model them in the form that we create a new interface (which could carry individual VLANs and so on) and then model the connection. Hence, there is no need for us to support multiple connected endpoints under an interface. If we encounter it, we fail. 2. Sites can have multiple ASNs now, ASNs are objects, not plain ints anymore. This is not an issue so far as a site currently only carries one ASN, which we simply unpack. Yet, I can imagine that we use multiple ASN in a site in the future in which case we would currently throw an exceptions. That's fine for now. If the time comes, we probably need to tag the ASN we want to use for the fabric.
Since netbox now supports tagging of VLAN groups, we can tag these groups and thus not have to rely on some lose convention if and when a VLAN group should considered to be always an extra vlan.
sebageek
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With netbox 3.0, there were 2 API changes that affect us:
Interfaces can now carry multiple connections, I believe is that is
to support broken out interfaces. We do not plan to have break outs
in the future, however we have them now. Yet we model them in the
form that we create a new interface (which could carry individual
VLANs and so on) and then model the connection. Hence, there is no
need for us to support multiple connected endpoints under an
interface. If we encounter it, we fail.
Sites can have multiple ASNs now, ASNs are objects, not plain ints
anymore. This is not an issue so far as a site currently only carries
one ASN, which we simply unpack. Yet, I can imagine that we use
multiple ASN in a site in the future in which case we would currently
throw an exceptions. That's fine for now. If the time comes, we
probably need to tag the ASN we want to use for the fabric.