Ignore EVPN networks for nullroutes/az aware routes #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When selecting the external subnets which will be part of the nullroute/az aware subnet routes sync we now ignore all subnets of networks that are tagged with gateway-host::cc-fabric. These tagged networks have their gateway on the EVPN side of the fabric. The question of if we should install a nullroute for a subnetpool with a prefix that contains an external network that has its gateway on the EVPN side the answer was yes, yes we should do this. Therefore it should be fine to just exclude the networks from the DB query.
swagner-de
approved these changes
Oct 10, 2024
sven-rosenzweig
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selecting the external subnets which will be part of the nullroute/az aware subnet routes sync we now ignore all subnets of networks that are tagged with gateway-host::cc-fabric. These tagged networks have their gateway on the EVPN side of the fabric.
The question of if we should install a nullroute for a subnetpool with a prefix that contains an external network that has its gateway on the EVPN side the answer was yes, yes we should do this. Therefore it should be fine to just exclude the networks from the DB query.