allocation sync: use physnet, not hostgroup name #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebageek
force-pushed
the
fix-allocation-sync-for-multiple-hostgroups-with-same-physnet
branch
from
86fea51
to
412d388
Compare
The allocation sync currently syncs the host allocations table by using the name of a hostgroup. This value is almost always the same as the physical network of the hostgroup, but not always. As new features will rely on multiple hostgroups belonging to the same physnet we need to fix this. While doing so we also make sure that if we have multiple hostgroups for the same physnet, we merge the vlan ranges we find in the different hostgroups (that's what the new sorting and grouping is for). In the config parser, we also now make sure the pyhsical_network config attribute is always set. For Converged Cloud, this is taken care of by the helm charts, but one can never be too sure (and this is not marked as a required attribute).
sebageek
force-pushed
the
fix-allocation-sync-for-multiple-hostgroups-with-same-physnet
branch
from
412d388
to
4048154
Compare
swagner-de
approved these changes
Jul 12, 2024
sebageek
deleted the
fix-allocation-sync-for-multiple-hostgroups-with-same-physnet
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The allocation sync currently syncs the host allocations table by using the name of a hostgroup. This value is almost always the same as the physical network of the hostgroup, but not always. As new features will rely on multiple hostgroups belonging to the same physnet we need to fix this.
While doing so we also make sure that if we have multiple hostgroups for the same physnet, we merge the vlan ranges we find in the different hostgroups (that's what the new sorting and grouping is for).
In the config parser, we also now make sure the pyhsical_network config attribute is always set. For Converged Cloud, this is taken care of by the helm charts, but one can never be too sure (and this is not marked as a required attribute).