Fix prune deleted volumes for clones #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
possible fix for #145 |
|
once clone split is started there are two cases
Consider this as RFC |
chuan137
requested changes
Jan 15, 2024
kpawar-sap
force-pushed
the
fix_delete_volume_periodic
branch
from
58eb373
to
4908df6
Compare
Carthaca
requested changes
Apr 22, 2024
During prune deleted volumes option, if volume is offline, manila calls for ONTAP volume-destroy API. However if volume has one or more clones, the destroy operation fails. So upon receving clone related error, check clone spilt status and if not started, start it.
kpawar-sap
force-pushed
the
fix_delete_volume_periodic
branch
from
4908df6
to
9271b71
Compare
Carthaca
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During prune deleted volumes option, if volume is offline, manila calls for ONTAP volume-destroy API. However if volume has one or more clones, the destroy operation fails. So upon receving clone related error, check clone spilt status and if not started, start it.