Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade go makefile maker, run #171

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

upgrade go makefile maker, run #171

wants to merge 9 commits into from

Conversation

notque
Copy link
Contributor

@notque notque commented Oct 4, 2024

atttempting to sort out issues, since they are in the pipeline need to push.

Upgraded my local go-makefile-maker in this process as well, so we'll see if we get the same errors, or new ones.

@coveralls
Copy link

coveralls commented Oct 4, 2024

Coverage Status

coverage: 58.917%. remained the same
when pulling 93bcca1 on codeql
into ec98d9b on master.

@notque
Copy link
Contributor Author

notque commented Oct 4, 2024

hrm, still failing. need to find the correct failure. This is obviously to do with the fact we use generated code. There's a todo to replace that, perhaps my energy would be better focused in accomplishing that. unsure.

@notque
Copy link
Contributor Author

notque commented Oct 4, 2024

Okay, adding make generate to the action file worked. it still fails due to a different issue I need to fix, but that's fine.

Okay, is it possible to add commands to go-makefile-maker within the actions file? Reading docs.

@notque
Copy link
Contributor Author

notque commented Oct 4, 2024

golangciLint:
createConfig: true
errcheckExcludes:
- io/ioutil.ReadFile
- io.Copy(*bytes.Buffer)
- io.Copy(os.Stdout)
- (net/http.Client).Do
skipDirs:
- easypg/migrate/

Is an option. I'd prefer we just generate the code though, looking into other options.

@notque
Copy link
Contributor Author

notque commented Oct 4, 2024

the thing is, the manual edit of the action will fix it... but it will be overwritten the next time go-makefile-maker is run...

so next week I'll loop others in and see what either silly error i'm making, or what feature we need in go-makefile-maker to support this.

or... change the way that it does generated files...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants