-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade go makefile maker, run #171
base: master
Are you sure you want to change the base?
Conversation
hrm, still failing. need to find the correct failure. This is obviously to do with the fact we use generated code. There's a todo to replace that, perhaps my energy would be better focused in accomplishing that. unsure. |
…ate to the checks?
Okay, adding make generate to the action file worked. it still fails due to a different issue I need to fix, but that's fine. Okay, is it possible to add commands to go-makefile-maker within the actions file? Reading docs. |
golangciLint:
|
the thing is, the manual edit of the action will fix it... but it will be overwritten the next time go-makefile-maker is run... so next week I'll loop others in and see what either silly error i'm making, or what feature we need in go-makefile-maker to support this. or... change the way that it does generated files... |
atttempting to sort out issues, since they are in the pipeline need to push.
Upgraded my local go-makefile-maker in this process as well, so we'll see if we get the same errors, or new ones.