Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clear resize error action to admin UI #1451

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Conversation

VoigtS
Copy link
Member

@VoigtS VoigtS commented Nov 1, 2024

Summary

Errors in Castellum that are from the type "resize" do not get immediately resolved when the error disappears. It only disappears after another resize attempt on the resource occurs. For this case a new API endpoint was introduced that clears an error from the database early. The follwing changes are present:

  • Add new Action column to the resize error table
  • Content is a "Clear" button that aims to remove the error from the error list.
  • Implement the API endpoint and the caller function
  • Refetch existing errors after calling the "Clear" functionality.

Screenshots (if applicable)

image

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@ArtieReus ArtieReus merged commit c73a64c into master Nov 4, 2024
4 checks passed
@ArtieReus ArtieReus deleted the clear_castellum_errors branch November 4, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants