Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manila): add minimum is critical feature to the UI #1448

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

VoigtS
Copy link
Member

@VoigtS VoigtS commented Oct 30, 2024

Summary

This is a manila UI change. Our customers desire the possibility to immediately scale their volume size if the option "Ensure this much free space" is set within the UI in order to solve sizing bottlenecks within the autoscaler. This PR implements a checkbox below this option which is only enabled if a input in the minimum size is present and attaches a attribute to the config that is then sent to the API.
The remaining differences of the file are formatting changes which occured by running the JS formatter which we use for our other projects.

Screenshots (if applicable)

image

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

Copy link
Collaborator

@andypf andypf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hgw77 hgw77 changed the title Add minimum is critical feature to the UI feat(manila): Add minimum is critical feature to the UI Nov 5, 2024
@hgw77 hgw77 changed the title feat(manila): Add minimum is critical feature to the UI feat(manila): add minimum is critical feature to the UI Nov 5, 2024
@andypf andypf merged commit afc304f into master Nov 5, 2024
4 checks passed
@andypf andypf deleted the castellum_minimum_free branch November 5, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants