Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cypress): fix tests #1447

Merged
merged 11 commits into from
Nov 4, 2024
Merged

chore(cypress): fix tests #1447

merged 11 commits into from
Nov 4, 2024

Conversation

hgw77
Copy link
Collaborator

@hgw77 hgw77 commented Oct 30, 2024

Summary

  • this will fix some failing tests

Related Issues

#1446

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@hgw77 hgw77 marked this pull request as ready for review October 30, 2024 15:10
Copy link
Collaborator

@ArtieReus ArtieReus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request looks good, but wouldn't be a good chance to improve it using element ID instead of generally looking for button text to check or do an action?

e2e/cypress/integration/admin/domain.js Show resolved Hide resolved
e2e/cypress/integration/member/dns.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@andypf andypf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andypf andypf merged commit 982cb45 into master Nov 4, 2024
4 checks passed
@andypf andypf deleted the hgw-fix-cypress-test branch November 4, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants