-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic ipv6 support #112
Open
sebageek
wants to merge
7
commits into
stable/yoga-m3
Choose a base branch
from
basic-ipv6-support
base: stable/yoga-m3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Basic ipv6 support #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebageek
force-pushed
the
basic-ipv6-support
branch
from
June 6, 2024 16:35
d9c6833
to
950e4d6
Compare
In VBInterface.postflight() we only need to call _update(), as we're already scoped to a router (and have a context).
With this patch we're supporting IPv6 partly in our infrastructure, at least for internal networks. This enables the v6 address family on our VRFs (if there is an IPv6 subnet connected to the router) and we configure IPv6 addresses on interfaces where needed. For BGPVPN we currently skip all v6 subnets. For extraroutes there is still testing to be done.
We can now configure IPv6 routes on our hardware routers, including default gateways. As we now return an empty dict if there are no routes we should no longer see any route diffs when the router has no default route configured.
sebageek
force-pushed
the
basic-ipv6-support
branch
2 times, most recently
from
November 14, 2024 10:27
f360938
to
d2ffc25
Compare
sebageek
force-pushed
the
basic-ipv6-support
branch
from
November 14, 2024 16:50
d2ffc25
to
0f3dfc5
Compare
Support announcing internal IPv6 CIDRs via BGPVPN, if we have them. This does not yet support route-targets / route-maps inside VRFs.
For our external prefixes we need support for IPv6 prefix lists.
We now support setting route-targets and export maps on the v6 address-family.
Route Maps can now reference IPv6 prefix lists. We also did some maintenance on the RouteMap class, like removing the unused enable_bgp flag and making sure that specifying both prefix_list and access_list don't override each other's match conditions (though this hasn't been used so far). As we don't know yet how we'll transport IPv6 prefixes from ACI/EVPN to our routers we'll for now leave the RoutePrefix to be v4 only and don't reference it for v6 addresses. Once we know how that part of the infra is going to work we'll fill it with life!
sebageek
force-pushed
the
basic-ipv6-support
branch
from
November 15, 2024 11:00
0f3dfc5
to
c7f8e1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is still some testing to be done. Also, the tests are not yet complete