Implement public-key authentication for netconf over ssh #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rotating credentials can be easier using key authentication for two reasons. 1. We read the key from disk on each authentication, allowing us to exchange the secret without having to restart the driver. 2. The device allows us to populate multiple keys for the same user. With credential rotation in mind, we implement the ability to use multiple keys and also report if authentication with those keys have been successful, allowing third party tooling to verify that it is safe to rotate a key. The `_connect` has also been moved from the `YangConnection` class to the `ASR1KContext` class. This has been done, as it was only using attributes of `ASR1KContext`, it was using none of the YangConnection attributes and could have been static. I also feel that is tightly coupled with the `ASR1KContext`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rotating credentials can be easier using key authentication for two
reasons.
exchange the secret without having to restart the driver.
With credential rotation in mind, we implement the ability to use
multiple keys and also report if authentication with those keys have
been successful, allowing third party tooling to verify that it is safe
to rotate a key.
The
_connecthas also been moved from theYangConnectionclass tothe
ASR1KContextclass. This has been done, as it was only usingattributes of
ASR1KContext, it was using none of the YangConnectionattributes and could have been static. I also feel that is tightly
coupled with the
ASR1KContext.