Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_hana_install: Implement an SAP HANA installation check only feature #849

Conversation

berndfinger
Copy link
Member

Fixes #844.

With this change, the role sap_hana_install can be used to perform an SAP HANA installation check without performing an installation.

@marcelmamula
Copy link
Contributor

@berndfinger Name of this PR and Issue gives me hint that this detects already installed HANA on target, but that is not case based on code that debugs variables, not actual target contents.

I would suggest maybe renaming it to something clearer.

@berndfinger
Copy link
Member Author

@berndfinger Name of this PR and Issue gives me hint that this detects already installed HANA on target, but that is not case based on code that debugs variables, not actual target contents.

The current version of the role can already check an existing HANA installation using one of these two methods, and it is doing this in the task named Perform an hdblcm installation check DIRECTLY AFTER a SAP HANA installation has been finished.

This PR, however, is only about adding the related tag to one more task so that the role does not fail when doing ONLY an installation check, in those cases where variables are used which have to be converted first.

Copy link
Contributor

@marcelmamula marcelmamula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berndfinger berndfinger merged commit 992895b into sap-linuxlab:dev Sep 4, 2024
3 of 4 checks passed
@berndfinger berndfinger deleted the issue-844-feature-hana-install-check-only branch September 4, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants