Retain IDF order and comments #261
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the functions to save the IDF in original order and retain comments
This reverts commit 0397524.
Added the saveinorder() function to retain the original order of IDF files and all the comments.
|
@hnagda , I am not seeing any unit tests. In principle, if you have good unit tests and all existing tests and new tests pass, the pull request should be accepted. even without looking at your code :-) In reality, we will look at your code and comment if needed. |
|
@hnagda - any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #260
The code was written about 3 months ago and it just works. There is a lot of room for improvement in the way its written (especially in withcomment() function). I would appreciate any comments or ideas to do things in a better way.