Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving NumericValue to double to ensure correctness during comparison #38

Merged
merged 4 commits into from
Jan 15, 2024
Merged

Moving NumericValue to double to ensure correctness during comparison #38

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f86ef11
Moving NumericValue to double to ensure correctness during comparison
Tushar-Naik Jan 15, 2024
6c194bb
Bumped up version
Tushar-Naik Jan 15, 2024
d978463
Comitting files changed by Github Actions
Tushar-Naik Jan 15, 2024
9590c2b
Added a test for equals, also changed from EvaluatableValue<Double> t…
Tushar-Naik Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Use the following dependency in your code.
<dependency>
<groupId>io.appform.hope</groupId>
<artifactId>hope-lang</artifactId>
<version>2.0.5</version>
<version>2.0.6</version>
</dependency>
```

Expand Down
2 changes: 1 addition & 1 deletion dependencies.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
io.appform.hope:hope:pom:2.0.5
io.appform.hope:hope:pom:2.0.6
+- org.openjdk.jmh:jmh-core:jar:1.35:test
| +- net.sf.jopt-simple:jopt-simple:jar:5.0.4:test
| \- org.apache.commons:commons-math3:jar:3.2:test
Expand Down
2 changes: 1 addition & 1 deletion hope-core/dependencies.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
io.appform.hope:hope-core:jar:2.0.5
io.appform.hope:hope-core:jar:2.0.6
+- org.reflections:reflections:jar:0.9.12:compile
| \- org.javassist:javassist:jar:3.26.0-GA:compile
+- org.openjdk.jmh:jmh-core:jar:1.35:test
Expand Down
2 changes: 1 addition & 1 deletion hope-core/dependency-reduced-pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<parent>
<artifactId>hope</artifactId>
<groupId>io.appform.hope</groupId>
<version>2.0.5</version>
<version>2.0.6</version>
</parent>
<modelVersion>4.0.0</modelVersion>
<artifactId>hope-core</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion hope-core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<parent>
<artifactId>hope</artifactId>
<groupId>io.appform.hope</groupId>
<version>2.0.5</version>
<version>2.0.6</version>
</parent>
<modelVersion>4.0.0</modelVersion>

Expand Down
4 changes: 2 additions & 2 deletions hope-core/src/main/java/io/appform/hope/core/values/NumericValue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,13 @@
@Data
@EqualsAndHashCode(callSuper = true)
@ToString(callSuper = true)
public class NumericValue extends EvaluatableValue<Number> {
public class NumericValue extends EvaluatableValue<Double> {

/**
* @param value Number value
*/
public NumericValue(Number value) {
super(value);
super(value.doubleValue());
}

/**
Expand Down
4 changes: 2 additions & 2 deletions hope-lang/dependencies.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
io.appform.hope:hope-lang:jar:2.0.5
+- io.appform.hope:hope-core:jar:2.0.5:compile
io.appform.hope:hope-lang:jar:2.0.6
+- io.appform.hope:hope-core:jar:2.0.6:compile
| \- org.reflections:reflections:jar:0.9.12:compile
| \- org.javassist:javassist:jar:3.26.0-GA:compile
+- ch.qos.logback:logback-classic:jar:1.2.10:test
Expand Down
2 changes: 1 addition & 1 deletion hope-lang/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<parent>
<artifactId>hope</artifactId>
<groupId>io.appform.hope</groupId>
<version>2.0.5</version>
<version>2.0.6</version>
</parent>
<modelVersion>4.0.0</modelVersion>

Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<groupId>io.appform.hope</groupId>
<artifactId>hope</artifactId>
<packaging>pom</packaging>
<version>2.0.5</version>
<version>2.0.6</version>

<name>Hope</name>
<url>https://github.com/santanusinha/hope</url>
Expand Down