Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support creating version with initial value #7878

Open
wants to merge 1 commit into
base: corel
Choose a base branch
from

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Nov 25, 2024

Description

Fixes an issue that made it impossible to create a new document in a release. Ideally you should be able to just start typing, but this fix at least makes it possible.

Also adds low-level API support for providing an initial/fallback value to use when adding a version to a document.

@bjoerge bjoerge requested a review from a team as a code owner November 25, 2024 17:10
@bjoerge bjoerge requested review from pedrobonamin and removed request for a team November 25, 2024 17:10
Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 5:15pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 5:15pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 5:15pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 5:15pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Nov 25, 2024 5:15pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Nov 25, 2024 5:17 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 9s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 40s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 53s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 15s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 2m 33s 1 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 8s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 36s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 45s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 40s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 53s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Mon, 25 Nov 2024 17:21:32 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 17.1 efps (59ms) 12.3 efps (81ms) +23ms (+38.5%) 🔴
article (body) 57.8 efps (17ms) 58.0 efps (17ms) -0ms (-0.3%)
article (string inside object) 18.5 efps (54ms) 13.2 efps (76ms) +22ms (+39.8%) 🔴
article (string inside array) 16.1 efps (62ms) 11.3 efps (89ms) +27ms (+42.7%) 🔴
recipe (name) 26.3 efps (38ms) 18.2 efps (55ms) +17ms (+44.7%) 🔴
recipe (description) 29.4 efps (34ms) 19.2 efps (52ms) +18ms (+52.9%) 🔴
recipe (instructions) 99.9+ efps (7ms) 99.9+ efps (7ms) +0ms (-/-%)
synthetic (title) 14.9 efps (67ms) 5.9 efps (170ms) +103ms (+153.7%) 🔴
synthetic (string inside object) 15.3 efps (66ms) 6.3 efps (158ms) +92ms (+140.5%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 59ms 65ms 82ms 296ms 623ms 13.4s
article (body) 17ms 20ms 37ms 190ms 281ms 5.9s
article (string inside object) 54ms 59ms 67ms 213ms 435ms 8.7s
article (string inside array) 62ms 66ms 80ms 229ms 689ms 9.4s
recipe (name) 38ms 41ms 44ms 80ms 4ms 9.3s
recipe (description) 34ms 36ms 42ms 67ms 1ms 6.4s
recipe (instructions) 7ms 7ms 9ms 13ms 4ms 3.5s
synthetic (title) 67ms 71ms 84ms 416ms 1634ms 15.1s
synthetic (string inside object) 66ms 70ms 92ms 379ms 1627ms 10.1s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 81ms 88ms 141ms 338ms 2635ms 15.6s
article (body) 17ms 22ms 54ms 140ms 689ms 7.0s
article (string inside object) 76ms 83ms 104ms 249ms 2592ms 11.5s
article (string inside array) 89ms 94ms 106ms 434ms 3336ms 12.4s
recipe (name) 55ms 59ms 63ms 123ms 1233ms 11.7s
recipe (description) 52ms 55ms 61ms 103ms 975ms 8.5s
recipe (instructions) 7ms 10ms 13ms 63ms 60ms 3.7s
synthetic (title) 170ms 176ms 194ms 693ms 9775ms 27.6s
synthetic (string inside object) 158ms 170ms 184ms 860ms 8399ms 19.0s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Copy link
Contributor

@pedrobonamin pedrobonamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @bjoerge , it looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants