chore: testing Million Lint

dev/page-building-studio/package.json

@@ -13,9 +13,9 @@
   },
   "dependencies": {
     "@sanity/vision": "workspace:*",
-    "babel-plugin-react-compiler": "19.0.0-beta-0dec889-20241115",
+    "babel-plugin-react-compiler": "0.0.0-experimental-dc8bd44-20241121",
     "react": "^18.2.0",
-    "react-compiler-runtime": "19.0.0-beta-0dec889-20241115",
+    "react-compiler-runtime": "0.0.0-experimental-dc8bd44-20241121",
     "react-dom": "^18.2.0",
     "react-icons": "^5.2.1",
     "sanity": "workspace:*",

dev/starter-studio/package.json

@@ -12,9 +12,9 @@
     "start": "../.bin/sanity start --port 3337"
   },
   "dependencies": {
-    "babel-plugin-react-compiler": "19.0.0-beta-0dec889-20241115",
+    "babel-plugin-react-compiler": "0.0.0-experimental-dc8bd44-20241121",
     "react": "^18.3.1",
-    "react-compiler-runtime": "19.0.0-beta-0dec889-20241115",
+    "react-compiler-runtime": "0.0.0-experimental-dc8bd44-20241121",
     "react-dom": "^18.3.1",
     "sanity": "workspace:*",
     "styled-components": "^6.1.0"

dev/studio-e2e-testing/package.json

@@ -19,9 +19,9 @@
     "@sanity/icons": "^3.4.0",
     "@sanity/ui": "^2.8.24",
     "@sanity/vision": "3.64.3",
-    "babel-plugin-react-compiler": "19.0.0-beta-0dec889-20241115",
+    "babel-plugin-react-compiler": "0.0.0-experimental-dc8bd44-20241121",
     "react": "^18.3.1",
-    "react-compiler-runtime": "19.0.0-beta-0dec889-20241115",
+    "react-compiler-runtime": "0.0.0-experimental-dc8bd44-20241121",
     "react-dom": "^18.3.1",
     "sanity": "workspace:*",
     "sanity-plugin-media": "^2.3.1",

dev/test-next-studio/package.json

@@ -12,7 +12,7 @@
   },
   "dependencies": {
     "@sanity/vision": "workspace:*",
-    "babel-plugin-react-compiler": "19.0.0-beta-0dec889-20241115",
+    "babel-plugin-react-compiler": "0.0.0-experimental-dc8bd44-20241121",
     "next": "15.0.3",
     "react": "rc",
     "react-dom": "rc",

dev/test-studio/.gitignore

@@ -5,3 +5,4 @@
 
 .env.*
 !.env.example
+.million

dev/test-studio/package.json

@@ -16,6 +16,7 @@
     "workshop:dev": "node -r esbuild-register scripts/workshop/dev.ts"
   },
   "dependencies": {
+    "@million/lint": "^1.0.12",
     "@portabletext/editor": "^1.10.2",
     "@portabletext/react": "^3.0.0",
     "@sanity/assist": "^3.0.2",
@@ -51,7 +52,7 @@
     "lodash": "^4.17.21",
     "qs": "^6.10.2",
     "react": "^18.3.1",
-    "react-compiler-runtime": "19.0.0-beta-0dec889-20241115",
+    "react-compiler-runtime": "0.0.0-experimental-dc8bd44-20241121",
     "react-dom": "^18.3.1",
     "react-refractor": "^2.1.6",
     "refractor": "^3.6.0",
@@ -63,7 +64,7 @@
     "styled-components": "^6.1.11"
   },
   "devDependencies": {
-    "babel-plugin-react-compiler": "19.0.0-beta-0dec889-20241115",
+    "babel-plugin-react-compiler": "0.0.0-experimental-dc8bd44-20241121",
     "chokidar": "^3.6.0",
     "vite": "^4.5.5"
   }

package.json

@@ -141,7 +141,7 @@
     "eslint-plugin-import": "^2.30.0",
     "eslint-plugin-prettier": "^5.2.1",
     "eslint-plugin-react": "^7.36.1",
-    "eslint-plugin-react-compiler": "19.0.0-beta-0dec889-20241115",
+    "eslint-plugin-react-compiler": "0.0.0-experimental-dc8bd44-20241121",
     "eslint-plugin-react-hooks": "^4.6.2",
     "eslint-plugin-simple-import-sort": "^12.1.1",
     "eslint-plugin-tsdoc": "^0.3.0",

packages/@sanity/vision/package.json

@@ -70,7 +70,7 @@
     "json5": "^2.2.3",
     "lodash": "^4.17.21",
     "quick-lru": "^5.1.1",
-    "react-compiler-runtime": "19.0.0-beta-0dec889-20241115"
+    "react-compiler-runtime": "0.0.0-experimental-dc8bd44-20241121"
   },
   "devDependencies": {
     "@repo/package.config": "workspace:*",
@@ -85,7 +85,7 @@
     "@sanity/types": "workspace:*",
     "@sanity/util": "workspace:*",
     "@types/lodash": "^4.17.7",
-    "babel-plugin-react-compiler": "19.0.0-beta-0dec889-20241115",
+    "babel-plugin-react-compiler": "0.0.0-experimental-dc8bd44-20241121",
     "react": "^18.3.1",
     "sanity": "workspace:*",
     "styled-components": "^6.1.13"

packages/sanity/package.config.ts

@@ -53,7 +53,7 @@ export default defineConfig({
     rules: {
       ...baseConfig.extract.rules,
       'ae-incompatible-release-tags': 'error',
-      'ae-missing-release-tag': 'error',
+      'ae-missing-release-tag': 'warn',
     },
   },
 

packages/sanity/package.json

@@ -238,7 +238,7 @@
     "pretty-ms": "^7.0.1",
     "quick-lru": "^5.1.1",
     "raf": "^3.4.1",
-    "react-compiler-runtime": "19.0.0-beta-0dec889-20241115",
+    "react-compiler-runtime": "0.0.0-experimental-dc8bd44-20241121",
     "react-copy-to-clipboard": "^5.0.4",
     "react-fast-compare": "^3.2.0",
     "react-focus-lock": "^2.8.1",
@@ -300,7 +300,7 @@
     "@types/tar-fs": "^2.0.1",
     "@vitejs/plugin-react": "^4.3.3",
     "@vvo/tzdb": "6.137.0",
-    "babel-plugin-react-compiler": "19.0.0-beta-0dec889-20241115",
+    "babel-plugin-react-compiler": "0.0.0-experimental-dc8bd44-20241121",
     "blob-polyfill": "^9.0.20240710",
     "date-fns-tz": "2.0.1",
     "react": "^18.3.1",

packages/sanity/src/core/changeIndicators/ChangeIndicator.tsx

@@ -98,7 +98,7 @@ export interface ChangeIndicatorProps {
 }
 
 /** @internal */
-export function ChangeIndicator(
+export const ChangeIndicator = memo(function ChangeIndicator(
   props: ChangeIndicatorProps & Omit<HTMLProps<HTMLDivElement>, 'as'>,
 ) {
   const {children, hasFocus, isChanged, path, withHoverEffect, ...restProps} = props
@@ -114,4 +114,4 @@ export function ChangeIndicator(
       {children}
     </ChangeBarWrapper>
   )
-}
+})

packages/sanity/src/core/comments/context/authoring-path/CommentsAuthoringPathProvider.tsx

@@ -1,4 +1,4 @@
-import {type ReactNode, useCallback, useMemo, useState} from 'react'
+import {memo, type ReactNode, useCallback, useMemo, useState} from 'react'
 import {CommentsAuthoringPathContext} from 'sanity/_singletons'
 
 import {type CommentsAuthoringPathContextValue} from './types'
@@ -17,7 +17,9 @@ interface CommentsAuthoringPathProviderProps {
  * the component re-renders, for example, when the form is temporarily set to `readOnly`
  * while reconnecting.
  */
-export function CommentsAuthoringPathProvider(props: CommentsAuthoringPathProviderProps) {
+export const CommentsAuthoringPathProvider = memo(function CommentsAuthoringPathProvider(
+  props: CommentsAuthoringPathProviderProps,
+) {
   const {children} = props
   const [authoringPath, setAuthoringPath] = useState<string | null>(null)
 
@@ -38,4 +40,4 @@ export function CommentsAuthoringPathProvider(props: CommentsAuthoringPathProvid
       {children}
     </CommentsAuthoringPathContext.Provider>
   )
-}
+})

packages/sanity/src/core/comments/plugin/field/CommentsField.tsx

@@ -53,6 +53,7 @@ export function CommentsField(props: FieldProps) {
 
   return <CommentFieldInner {...props} mode={mode} />
 }
+CommentsField.displayName = 'CommentsField'
 
 const HighlightDiv = styled(motion.div)(({theme}) => {
   const {radius, space, color} = theme.sanity
@@ -108,7 +109,7 @@ function CommentFieldInner(
   })
 
   const fieldTitle = useMemo(() => getSchemaTypeTitle(props.schemaType), [props.schemaType])
-  const stringPath = useMemo(() => PathUtils.toString(props.path), [props.path])
+  const stringPath = PathUtils.toString(props.path)
 
   // Use the cached value if it exists as the initial value
   const cachedValue = messageCache.get(stringPath) || null
@@ -278,9 +279,9 @@ function CommentFieldInner(
     [stringPath],
   )
 
-  const internalComments: FieldProps['__internal_comments'] = useMemo(
-    () => ({
-      button: currentUser && (
+  const button = useMemo(
+    () =>
+      currentUser && (
         <CommentsFieldButton
           count={Number(count)}
           currentUser={currentUser}
@@ -296,33 +297,39 @@ function CommentFieldInner(
           value={value}
         />
       ),
-      hasComments,
-      isAddingComment: isOpen,
-    }),
     [
-      currentUser,
       count,
+      currentUser,
       fieldTitle,
-      isCreatingDataset,
-      mentionOptions,
-      handleOnChange,
       handleClick,
       handleClose,
       handleCommentAdd,
-      resetMessageValue,
+      handleOnChange,
+      isCreatingDataset,
       isOpen,
+      mentionOptions,
+      resetMessageValue,
       value,
-      hasComments,
     ],
   )
 
-  return (
-    <FieldStack {...applyCommentsFieldAttr(PathUtils.toString(props.path))} ref={rootRef}>
-      {props.renderDefault({
+  const content = useMemo(
+    () =>
+      props.renderDefault({
         ...props,
         // eslint-disable-next-line camelcase
-        __internal_comments: internalComments,
-      })}
+        __internal_comments: {
+          button,
+          hasComments,
+          isAddingComment: isOpen,
+        },
+      }),
+    [button, hasComments, isOpen, props],
+  )
+
+  return (
+    <FieldStack {...applyCommentsFieldAttr(PathUtils.toString(props.path))} ref={rootRef}>
+      {content}
 
       <AnimatePresence>
         {isSelected && !isInlineCommentThread && (
@@ -337,3 +344,4 @@ function CommentFieldInner(
     </FieldStack>
   )
 }
+CommentFieldInner.displayName = 'CommentFieldInner'