Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): when publishing a release unpin it #7862

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

pedrobonamin
Copy link
Contributor

Description

Once a released is published (archived), it should be unpinned if it was pinned, to avoid bugs in the rest of the system.

What to review

Testing

Notes for release

@pedrobonamin pedrobonamin requested a review from a team as a code owner November 22, 2024 08:33
@pedrobonamin pedrobonamin requested review from jordanl17 and removed request for a team November 22, 2024 08:33
Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 10:28am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 10:28am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 10:28am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 10:28am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 10:28am

Copy link
Contributor

@RitaDias RitaDias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Nov 22, 2024

Component Testing Report Updated Nov 22, 2024 10:28 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 6s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 39s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 53s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 35s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 42s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 39s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 53s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Nov 22, 2024

⚡️ Editor Performance Report

Updated Fri, 22 Nov 2024 10:31:00 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 17.7 efps (57ms) 12.4 efps (81ms) +24ms (+42.5%) 🔴
article (body) 56.8 efps (18ms) 56.5 efps (18ms) +0ms (+0.6%)
article (string inside object) 18.9 efps (53ms) 13.5 efps (74ms) +21ms (+39.6%) 🔴
article (string inside array) 16.1 efps (62ms) 11.4 efps (88ms) +26ms (+41.9%) 🔴
recipe (name) 30.3 efps (33ms) 20.0 efps (50ms) +17ms (+51.5%) 🔴
recipe (description) 33.3 efps (30ms) 21.1 efps (48ms) +18ms (+58.3%) 🔴
recipe (instructions) 99.9+ efps (7ms) 99.9+ efps (6ms) -1ms (-/-%)
synthetic (title) 13.7 efps (73ms) 5.5 efps (183ms) +110ms (+150.7%) 🔴
synthetic (string inside object) 13.9 efps (72ms) 5.7 efps (175ms) +103ms (+142.4%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 57ms 62ms 91ms 278ms 506ms 12.8s
article (body) 18ms 20ms 28ms 182ms 280ms 5.9s
article (string inside object) 53ms 57ms 68ms 280ms 473ms 8.6s
article (string inside array) 62ms 68ms 77ms 406ms 966ms 9.4s
recipe (name) 33ms 36ms 56ms 91ms 0ms 9.4s
recipe (description) 30ms 32ms 35ms 126ms 0ms 6.1s
recipe (instructions) 7ms 9ms 10ms 12ms 0ms 3.3s
synthetic (title) 73ms 77ms 83ms 443ms 1742ms 16.5s
synthetic (string inside object) 72ms 76ms 80ms 429ms 1595ms 10.8s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 81ms 89ms 105ms 318ms 3063ms 16.8s
article (body) 18ms 26ms 50ms 275ms 573ms 6.5s
article (string inside object) 74ms 78ms 85ms 370ms 2605ms 11.2s
article (string inside array) 88ms 91ms 102ms 334ms 3354ms 12.3s
recipe (name) 50ms 53ms 72ms 114ms 877ms 12.1s
recipe (description) 48ms 50ms 99ms 121ms 752ms 8.2s
recipe (instructions) 6ms 8ms 9ms 10ms 0ms 3.3s
synthetic (title) 183ms 197ms 285ms 599ms 9994ms 31.1s
synthetic (string inside object) 175ms 193ms 304ms 705ms 10452ms 22.6s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants