feat(releases): timezone selection updates filtering and dateTime display on release overview #7854
+178
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… differs from locale
… differs from locale
…nity into corel-239-overview-timezone
…nity into corel-239-overview-timezone
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Nov 21, 2024 4:55 PM (UTC) ✅ All Tests Passed -- expand for details
|
⚡️ Editor Performance ReportUpdated Thu, 21 Nov 2024 16:58:05 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
… differs from locale
…sanity into corel-239-overview-timezone-2
jordanl17
requested review from
cngonzalez and
RitaDias
and removed request for
a team and
cngonzalez
RitaDias
reviewed
Nov 21, 2024
Comment on lines
32
to
34
| if (timeZone.abbreviation === localeTimeZoneAbbreviation) return '' | ||
|
|
||
| return `(${timeZone.abbreviation})` |
There was a problem hiding this comment.
super small nit but you can always make this be
Suggested change
| if (timeZone.abbreviation === localeTimeZoneAbbreviation) return '' | |
| return `(${timeZone.abbreviation})` | |
| return timeZone.abbreviation === localeTimeZoneAbbreviation ? '' : `(${timeZone.abbreviation})` |
right?
There was a problem hiding this comment.
So much nicer, thank you!
RitaDias
reviewed
Nov 21, 2024
| import useTimeZone, {getLocalTimeZone} from '../../useTimeZone' | ||
|
|
||
| const mockTimeZone: NormalizedTimeZone = { | ||
| abbreviation: 'SCT', // Sanity Central Time :) |
RitaDias
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Above demonstrates that:
What to review
Note that
useTimeZoneand a few other helpers were introduced inScheduledPublishingand still exist nested in that directory.As part of a quick follow PR (coming shortly), I'll move these parts that are now shared across content releases and scheduled publishing to a more generic place.
Testing
Updated tests for
ReleasesOverviewAdded mocks for
useTimeZoneNotes for release
N/A