Add ToolOptionsProvider in the Studio layout component
#223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snorrees
reviewed
Jul 19, 2024
azaxarov
force-pushed
the
fix/az/media-tool-options
branch
from
a42d3f1
to
fd608c6
Compare
azaxarov
changed the title
withToolOptions HOCToolOptionsProvider in the Studio layout component
azaxarov
force-pushed
the
fix/az/media-tool-options
branch
from
fd608c6
to
09d6f22
Compare
snorrees
requested changes
Jul 19, 2024
src/index.ts
Outdated
| ] | ||
| } | ||
| })) | ||
| export {media} from './plugin' |
There was a problem hiding this comment.
As is, this is a breaking change (no longer exporting the asset source).
You could do
Suggested change
| export {media} from './plugin' | |
| export * from './plugin' |
But I prefer us being explicit
Suggested change
| export {media} from './plugin' | |
| export {media, mediaAssetSource} from './plugin' |
Looking at it now, we probably should export MediaToolOptions too, since its used in userland
Suggested change
| export {media} from './plugin' | |
| export {media, mediaAssetSource} from './plugin' | |
| export {MediaToolOptions} from '@types' |
There was a problem hiding this comment.
Good suggestions! Added now 👍
azaxarov
force-pushed
the
fix/az/media-tool-options
branch
from
09d6f22
to
58bb52c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses an issue introduced in #221, where some custom asset source components for files and images did not have access to the tool options context.