Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-327 [Sequencescape] Generate FluidX barcodes UAT action #4400

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

yoldas
Copy link
Member

@yoldas yoldas commented Oct 7, 2024

Closes #

Changes proposed in this pull request

  • Adds a UAT action to generate randomised FluidX barcodes.
  • It checks existing barcodes to generate unique barcodes

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@yoldas yoldas linked an issue Oct 7, 2024 that may be closed by this pull request
4 tasks
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.77%. Comparing base (ed77842) to head (b62f769).
Report is 54 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4400      +/-   ##
===========================================
+ Coverage    87.72%   87.77%   +0.04%     
===========================================
  Files         1397     1398       +1     
  Lines        30099    30233     +134     
===========================================
+ Hits         26405    26537     +132     
- Misses        3694     3696       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@andrewsparkes andrewsparkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thorough tests

@yoldas yoldas merged commit 93e2c9a into develop Oct 8, 2024
23 checks passed
@yoldas yoldas deleted the y24-327-generate-fluidx-barcodes-uat-action branch October 8, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Y24-327 - scRNA Core bulk test
2 participants