Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-051: Add description to pools tab #2080

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

StephenHulme
Copy link
Contributor

@StephenHulme StephenHulme commented Nov 21, 2024

Closes #1667

Changes proposed in this pull request

  • Adds a description to the Pools tab to clarify that it reflects a planned future state and not the current state.

Screenshot

Screenshot 2024-11-21 at 14 21 36

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@StephenHulme StephenHulme changed the title fix: add description to pools tab Y24-051: Add description to pools tab Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.09%. Comparing base (abd7f03) to head (581a0ba).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2080   +/-   ##
========================================
  Coverage    78.09%   78.09%           
========================================
  Files          477      477           
  Lines        18066    18066           
  Branches       262      262           
========================================
  Hits         14109    14109           
  Misses        3955     3955           
  Partials         2        2           
Flag Coverage Δ
javascript 69.89% <ø> (ø)
pull_request 78.09% <ø> (ø)
push 78.09% <ø> (ø)
ruby 91.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@andrewsparkes
Copy link
Member

I think we also have in the backlog somewhere that this pool tab is just not relevant for a lot of pipelines and is misleading / wrong to see for plates in many of those (i.e. this is a common tab that shouldn't be quite so common).
But this story is a good clarification of meaning.

@StephenHulme
Copy link
Contributor Author

I think we also have in the backlog somewhere that this pool tab is just not relevant for a lot of pipelines and is misleading / wrong to see for plates in many of those (i.e. this is a common tab that shouldn't be quite so common). But this story is a good clarification of meaning.

Yes, I think that's this story by implication - but it's not explicitly stated... I'll have another look before creating a new story.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Y24-051 [BUG] Limber can display an incorrect nonexistent pool and incorrect warnings for some stock plates.
2 participants