Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release "DPL-1054 Add Vac tube barcode to the Aliquot tube labels", and dependency updates #1614

Merged
merged 37 commits into from
Mar 6, 2024

Conversation

KatyTaylor
Copy link
Contributor

@KatyTaylor KatyTaylor commented Mar 6, 2024

Changes proposed in this pull request

  • DPL-1054 Add Vac tube barcode to the Aliquot tube labels
  • Dependency updates
  • README updates
  • Pipeline graph css changes
  • Small change to scRNA Core cDNA Prep pipeline (feature flagged off)

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

KatyTaylor and others added 30 commits February 7, 2024 13:11
- add LRC Blood Vac as the alternative workline identifier for LRC Blood Aliquot tubes
- the top right section is blank on the current LRC Blood Aliquot labels, so this will fill it in
fix: address 'compound selectors may no longer be extended' warning
docs: add some troubleshooting tips to readme
🚨 [security] [ruby] Update yard 0.9.34 → 0.9.35 (minor)
🚨 [security] [ruby] Update rails 7.1.3 → 7.1.3.2 (minor)
[ruby] Update all Bundler dependencies (2024-03-01)
KatyTaylor and others added 7 commits March 1, 2024 15:41
…into-Sequencescape

DPL-823 Import PBMC pool plates into Sequencescape
…-the-Aliquot-tube-labels

DPL-1054 Add Vac tube barcode to the Aliquot tube labels
[ruby] Update all Bundler dependencies (2024-03-03)
[ruby] Update all Bundler dependencies (2024-03-04)
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 90.50633% with 30 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (master@d08cc42). Click here to learn what that means.

Files Patch % Lines
lib/purpose_config.rb 36.36% 7 Missing ⚠️
...creators/pcr_cycles_binned_plate_for_t_nano_seq.rb 76.92% 6 Missing ⚠️
lib/tasks/config.rake 0.00% 5 Missing ⚠️
..._creators/pcr_cycles_binned_plate/csv_file_base.rb 76.92% 3 Missing ⚠️
...s/labware_creators/pcr_cycles_binned_plate_base.rb 50.00% 3 Missing ⚠️
...esenters/pcr_cycles_binned_plate_presenter_base.rb 60.00% 2 Missing ⚠️
...ators/pcr_cycles_binned_plate/csv_file/row_base.rb 97.87% 1 Missing ⚠️
..._binned_plate/csv_file/well_details_header_base.rb 93.33% 1 Missing ⚠️
.../utility/pcr_cycles_csv_file_upload_config_base.rb 75.00% 1 Missing ⚠️
...cr_cycles_for_duplex_seq_csv_file_upload_config.rb 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1614   +/-   ##
=========================================
  Coverage          ?   90.65%           
=========================================
  Files             ?      355           
  Lines             ?     7279           
  Branches          ?        0           
=========================================
  Hits              ?     6599           
  Misses            ?      680           
  Partials          ?        0           
Flag Coverage Δ
javascript 93.64% <100.00%> (?)
pull_request 90.65% <90.50%> (?)
push 90.65% <90.50%> (?)
ruby 90.22% <90.41%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KatyTaylor KatyTaylor merged commit ab39dc1 into master Mar 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants