Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release DPL-977, DPL-1043 & DPL-1059 #1590

Merged
merged 76 commits into from
Feb 21, 2024
Merged

Release DPL-977, DPL-1043 & DPL-1059 #1590

merged 76 commits into from
Feb 21, 2024

Conversation

KatyTaylor
Copy link
Contributor

Changes proposed in this pull request

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

depfu bot and others added 30 commits November 10, 2023 02:06
@depfu
Update axios to version 1.6.1
ec79eec
@StephenHulme
wip: attempt to combine multiple code coverage files
9ad6909
@StephenHulme
build: set coverage file locations
10996e2
@StephenHulme
build: rename github test actions
bc0e535
@StephenHulme
wip: add coverage file caching and retrieval
f2cdc35
@StephenHulme
Merge branch 'develop' into sh51/combine-coverage
c2af99b
@StephenHulme
wip: debug
ab42e13
@andrewsparkes
separated out targeted nanoseq customer file handling and made the re…
2c8c6b3 
…quired column changes
@andrewsparkes
Merge branch 'dpl-975c-t-nanoseq-limber-poly-metadata-via-api-v2' int…
392feea 
…o dpl-976-modify-customer-file-handling
@andrewsparkes
updated fields array and removed unneeded comments
bc7a94a
@andrewsparkes
added labware creator specific for targeted nanoseq
a716af1
@andrewsparkes
fix child plate creation in test (incorrect aliquot and request place…
44e7e9b 
…ment
@andrewsparkes
added check for metadata creation method calls
54182e6
@andrewsparkes
Merge branch 'develop' into dpl-976-modify-customer-file-handling
6355a74
@andrewsparkes
updated docs
676f1b9
@StephenHulme
build: add compile test workflow
638bbd3
@andrewsparkes
fix test adding extra metadata pairs
840cec1
@StephenHulme
fix: change workflow name
4497d45
@StephenHulme
fix: hey look, a shift key!
02ebefb
@StephenHulme
fix: spelling...
63942c7
@depfu
Update core-js to version 3.35.1
da901b4
@andrewsparkes
removed comments
9fab958
@andrewsparkes
Merge branch 'develop' into dpl-976-modify-customer-file-handling
f771d48
@andrewsparkes
created merged file to replace existing export file for targeted nano…
ebe0dfd 
…seq, using request poly_metadata
@andrewsparkes
fix includes in test to match code
85937a1
@depfu
Update rspec-rails to version 6.1.1
e81af5d
@andrewsparkes
refactored to dry out code
220278e
@andrewsparkes
Merge branch 'dpl-976-modify-customer-file-handling' into dpl-977-upd…
bff7559 
…ate-tnano-export-file
@andrewsparkes
corrected export file sort order to by column
98c42c0
@KatyTaylor
Create a 'plate_a' label template and use it in the purpose config fo…
102356d 
…r LRC Blood Aliquot

- this solution seems to work (printers drop down changes in the UI), but I'm not sure it's a good solution - may refactor
KatyTaylor and others added 27 commits February 12, 2024 13:59
@KatyTaylor
rubocop
2bd867b
@KatyTaylor
Merge pull request #1573 from sanger/DPL-1043-Change-label-type-for-L…
4f33667 
…RC-Blood-Aliquot

Label template refactor
@StephenHulme
fix: remove unnecessary scrollbars on page zoom
3aa96b3
@StephenHulme
fix: centre text and show over-flow when it happens
0cce87d
@yoldas
Merge pull request #1572 from sanger/depfu/update/nokogiri-1.16.2
54e7450 
🚨 [security] [ruby] Update nokogiri 1.16.0 → 1.16.2 (patch)
@depfu
Update all Bundler dependencies (2024-02-12)
e8ae98d
@yoldas
Merge pull request #1557 from sanger/depfu/batch_all/2024-01-22
a08fd95 
[ruby] Update all Bundler dependencies (2024-02-12)
@StephenHulme
build: upgrade to axios 0.28.0
38d2bc8
@StephenHulme
Merge pull request #1458 from sanger/depfu/update/yarn/axios-1.6.1
e161699 
🚨 [security] [js] Update axios 0.21.4 → 1.6.1 (major)
@StephenHulme
Merge pull request #1552 from sanger/sh51/add-compile-test-workflow
82babf8 
build: add compile test workflow
@dasunpubudumal
Update LICENSE
d23561c 
Updating Licence to MIT
@StephenHulme
refactor: replace CodeClimate with CodeCov
69c444c 
TODO: add back code-climate for transition
@StephenHulme
fix: repair missing token error
25be93b
@StephenHulme
fix: prevent duplicate file uploads
166d5af
@StephenHulme
fix: remove old comments
b463b8e
@StephenHulme
fix: restore code climate upload
8e3dd88
@StephenHulme
Merge branch 'develop' into sh51/combine-coverage
ffdb01b
@dasunpubudumal
Merge pull request #1581 from sanger/update-licence
1107483 
Update LICENSE
@StephenHulme
Merge pull request #1579 from sanger/dpl-1059-fix-scrolling
c07846c 
DPL-1059: fix - remove unnecessary scrollbars on page zoom
@StephenHulme
Merge pull request #1520 from sanger/sh51/combine-coverage
29431cc 
DPL-1034: Combine code coverage from both Javascript and Ruby code
@andrewsparkes
removed pcr_cycles column from customer file download after uat feedback
f0d1119
@andrewsparkes
Merge branch 'develop' into dpl-977-update-tnano-export-file
92358f6
@yoldas
Merge pull request #1562 from sanger/dpl-977-update-tnano-export-file
0e7954d 
DPL-977 Targeted NanoSeq -created merged file
@StephenHulme
build: exclude Vue SFC from coverage stats until #1585 is addressed
45d8027
@StephenHulme
style: lint
c9cb872
@StephenHulme
Merge pull request #1589 from sanger/sh51-filter-out-vue-coverage
4a9a421 
build: exclude Vue SFC from coverage stats until #1585 is addressed
@KatyTaylor
bump release version
87f4aa7
StephenHulme
StephenHulme approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@StephenHulme StephenHulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone through the code, and see no debug code or extraneous print statements.

🚀

@KatyTaylor KatyTaylor merged commit e16f6ea into master Feb 21, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenHulme StephenHulme StephenHulme approved these changes

@yoldas yoldas yoldas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KatyTaylor @yoldas @StephenHulme @andrewsparkes @dasunpubudumal