Fix barycentric interpolation on Windows #18
+52
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many tests were failing on Windows due to a buffer dtype mismatch (cross-platform Cython issue, as discussed previously).
Addressed largely by specifying int type used in numpy arrays in inner functions (both in Python and Cython). I have kept fused type declaration as it is likely catching other use/edge cases.
On Windows, the number of failing tests have gone down from 44 to 22, none of which are related to buffer mismatches.
No buffer mismatch errors are raised when running tests on Ubuntu 20.04 (although 15 do fail).
I am assuming the failing tests cover pieces of work still in progress.