Check opencsp.app for doc strings #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e10harvey
commented
Apr 17, 2024
e10harvey
commented
Apr 17, 2024
e10harvey
force-pushed
the
doc_strings_exist
branch
from
3a76c58
to
5603cb7
Compare
braden6521
reviewed
Apr 17, 2024
braden6521
reviewed
Apr 17, 2024
braden6521
reviewed
Apr 17, 2024
braden6521
reviewed
Apr 17, 2024
There was a problem hiding this comment.
I do not know what this file does; @rcbrost contributed this. At the moment, the script is broken and does not run. I would recommend removing it from the develop branch if we cannot fix it soon.
braden6521
reviewed
Apr 17, 2024
braden6521
reviewed
Apr 17, 2024
Comment on lines
38
to
52
| """ | ||
| Placeholder | ||
| """ |
There was a problem hiding this comment.
@rcbrost contributed this function.
Note: as of now, this function is broken. Should be removed from develop or fixed.
braden6521
reviewed
Apr 17, 2024
3 tasks
e10harvey
force-pushed
the
doc_strings_exist
branch
2 times, most recently
from
a25a187
to
f069eac
Compare
|
This needs a rebase |
e10harvey
force-pushed
the
doc_strings_exist
branch
from
f069eac
to
e296ab5
Compare
braden6521
previously approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: Please add suggestions for the 'Placeholder' doc strings or @ mention someone who can fill this in. Thank you.