16 making testmotionbasedcantingpy pass #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbean23
requested changes
Apr 15, 2024
There was a problem hiding this comment.
- There's a number of changes here that I'd like for you address before I approve.
- Please update the code and tests so that all the CI automation passes.
- I hope the tests work, because I didn't really read much of the test files. 🤫
- I suggest adding a few simple tests for planes_line_intersection.py/IntersectionBinarySearch.py
mhhwang1
force-pushed
the
16-making-testmotionbasedcantingpy-pass
branch
from
a577f14
to
a23787d
Compare
mhhwang1
force-pushed
the
16-making-testmotionbasedcantingpy-pass
branch
from
a23787d
to
5b6ba57
Compare
mhhwang1
force-pushed
the
16-making-testmotionbasedcantingpy-pass
branch
from
5b6ba57
to
b615ff2
Compare
…cet, and solarfield classes to differentiate two origins.
mhhwang1
force-pushed
the
16-making-testmotionbasedcantingpy-pass
branch
from
b615ff2
to
80e5f28
Compare
e10harvey
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds TstMotionBasedCanting to determine the azimuth and elevation angles required to hit a target on the top of the towers.
Includes changes to files (heliostat, solarfield, and facet) to make it run, along with new tower files to render a tower for target location.
Need to add unit tests to server, waiting on future changes to facet class. Will later edit TstMotionBasedCanting to also compute canting angles of heliostat.